Conversation
- Create or update accounts for creator and assignee - Link accounts to issues in the database - Add account data to issues_output.csv - Verify account data with snapshot_tables/accounts.csv #8400
dosubot
Bot
added
size:L
d4x1
previously approved these changes
Apr 24, 2025
| var err errors.Error | ||
| var id string | ||
| if record["id"] == nil { | ||
| idValue, ok := record["id"] |
Contributor
There was a problem hiding this comment.
I've seen some duplicated codes like:
idValue, ok := record["id"]
if !ok || idValue == nil {
return errors.Default.New("record without id")
}
id, ok := idValue.(string)
if !ok || id == "" {
return errors.Default.New("invalid or empty id")
}
I think we can simplify a function.
Collaborator
Author
There was a problem hiding this comment.
Fixed. The relevant logic has been extracted into a getStringField function, and a test case has been added for it.
| return "", nil // Return empty ID if name is empty, no error needed here. | ||
| } | ||
| now := time.Now() | ||
| accountId := fmt.Sprintf("csv:CsvAccount:0:%s", accountName) |
Contributor
There was a problem hiding this comment.
Is 0 in csv:CsvAccount:0:%s correct? I am not sure.
Collaborator
Author
There was a problem hiding this comment.
CSV is not a real data source within the system; there are no plugins or connections specifically for CSV. This ID is a mock, designed to match the format of other entities, so all data obtained through the API (which is in CSV format) shares this single "connection".
…d handling - Add getStringField function to extract and validate string fields from records - Use getStringField to replace repetitive code in issueHandlerFactory - Add unit tests for getStringField to ensure its correctness #8400
d4x1
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8400
pr-type/bug-fix,pr-type/feature-development, etc.Summary
What does this PR do?
Does this close any open issues?
Closes xx
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.